Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds mistralai as a gen_ai.system attribute value #1719

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codefromthecrypt
Copy link
Contributor

This extends GenAI System to include Mistral AI. This accessed either via its native 'mistralai' API or via OpenAI libraries.

This is a follow-up to #1655

Changes

Added the following:

  • "mistralai", not "mistral" as their client library is named "mistralai", despite some of their models named "mistral-XXX"

Merge requirement checklist

Copy link
Member

@drewby drewby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition looks good to me.

@@ -61,6 +61,10 @@ groups:
stability: experimental
value: "groq"
brief: 'Groq'
- id: mistralai
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it's spelled as two words in the docs and on the trademark I believe it should be

Suggested change
- id: mistralai
- id: mistral_ai

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so in the README I wrote this:

"mistralai", not "mistral" as their client library is named "mistralai", despite some of their models named "mistral-XXX"

do we want to use a convention different than what they are using? ok by me, but worth the question.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bam4d since you are from mistral, maybe you can answer this question. OpenTelemetry will make signals like metrics, and a dimension of the metrics is where chat requests are coming from. For Mistral AI, should the string be "mistralai" or "mistral_ai" (or something else). We just want to use a coherent value and there are multiple seemingly correct choices.

Thanks for letting us randomly ping you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants