[vcs] add vcs.change.time_to_merge metric
#1685
Conversation
There was a problem hiding this comment.
The vcs.change.time_to_merge metric was removed in the previous PR following this discussion: #1383 (comment)
I thought that vcs.change.state attribute on the vcs.change.duration metric was sufficient to distinguish them, but it makes sense to have time_to_merge separate.
| - ref: vcs.ref.head.name | ||
| requirement_level: required | ||
| - ref: vcs.ref.head.revision | ||
| requirement_level: recommended |
There was a problem hiding this comment.
Should the revision attributes be opt-in instead of recommended due to the cardinality issue?
There was a problem hiding this comment.
I don't have a strong opinion in either direction. Cardinality is a storage concern, but I'm less sure it's a semantic one. recommended and opt-in both provide users the choice in the event cardinality is a concern for them.
There was a problem hiding this comment.
I think it's fine for the revision attributes to be recommended for the vcs.change.time_to_merge metric because they are not expected to change after the PR is merged.
However I would make the revision attributes opt-in for the time_to_approval metric because there they could still change if the PR receives additional commits.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
There was a problem hiding this comment.
This file is missing a section for the new vcs.change.time_to_merge metric.
Ie the following needs to be added:
### Metric: `vcs.change.time_to_merge`
This metric is [recommended][MetricRecommended].
<!-- semconv metric.vcs.change.time_to_merge -->
<!-- endsemconv -->
Running make fix afterwards will fill in the tables in the generated block.
| - ref: vcs.ref.head.name | ||
| requirement_level: required | ||
| - ref: vcs.ref.head.revision | ||
| requirement_level: recommended |
There was a problem hiding this comment.
I think it's fine for the revision attributes to be recommended for the vcs.change.time_to_merge metric because they are not expected to change after the PR is merged.
However I would make the revision attributes opt-in for the time_to_approval metric because there they could still change if the PR receives additional commits.
Changes
Adds the
vcs.change.time_to_mergemetric from the GitHub Receiver. It didn't make as part of a previous pull request.Merge requirement checklist
[chore]