otel-arrow updates for Collector MetricLevel deprecation steps in v0.119.0 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewrelmas
commented
Feb 6, 2025
...tor/processor/concurrentbatchprocessor/internal/metadatatest/generated_telemetrytest_test.go
Show resolved
Hide resolved
drewrelmas
requested review from
lquerel,
jmacd,
moh-osman3 and
codeboten
as code owners
drewrelmas
changed the title
jmacd
approved these changes
Feb 6, 2025
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #280, follow-up to #283 and open-telemetry/opentelemetry-collector-contrib#37512.
Now that the Collector-Contrib
otelarrowreceiverin release v0.119.0 uses theWithMeterProviderAltfunction, it is safe to change the signature ofWithMeterProviderto follow through on the deprecation ofMetricsLevel.After another otel-arrow release and subsequent contrib release, will remove the
Altfunction entirely.Finally, updated the
mdatagenresult inconcurrentbatchprocessorto reflect the additional deprecation ofMetricsLevelfollowing upstream activity at https://github.com/open-telemetry/opentelemetry-collector/tree/main/processor/batchprocessor.