Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix active context is removed wrongly #448

Conversation

nachoBonafonte
Copy link
Member

We must only reset current context when the span being ended is the active span

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (46c8adc) 66.32% compared to head (309f597) 66.37%.

❗ Current head 309f597 differs from pull request most recent head c3e0df5. Consider uploading reports for the commit c3e0df5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   66.32%   66.37%   +0.05%     
==========================================
  Files         331      331              
  Lines       14109    14113       +4     
==========================================
+ Hits         9358     9368      +10     
+ Misses       4751     4745       -6     
Files Changed Coverage Δ
...nTelemetryApi/Context/ActivityContextManager.swift 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vvydier vvydier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@nachoBonafonte
Copy link
Member Author

Fixes #420

@nachoBonafonte nachoBonafonte merged commit 27e3fec into open-telemetry:main Aug 3, 2023
3 of 4 checks passed
@nachoBonafonte nachoBonafonte deleted the fix-active-context-is-removed-wrongly branch November 16, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants