Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added protobuf version as exporter user-agent version #444

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

bryce-b
Copy link
Member

@bryce-b bryce-b commented Jul 24, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.03% ⚠️

Comparison is base (27e3fec) 66.37% compared to head (762022b) 66.35%.

❗ Current head 762022b differs from pull request most recent head bb17394. Consider uploading reports for the commit bb17394 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   66.37%   66.35%   -0.03%     
==========================================
  Files         331      331              
  Lines       14113    14113              
==========================================
- Hits         9368     9365       -3     
- Misses       4745     4748       +3     
Files Changed Coverage Δ
...s/OpenTelemetryProtocolCommon/common/Headers.swift 88.88% <87.50%> (-11.12%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vvydier vvydier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to update this with every release? or is there a way to pick it up from the release meta data?

@bryce-b
Copy link
Member Author

bryce-b commented Jul 24, 2023

@vvydier only when we update the protobufs. which reminds me: I should update the docs to note this.

@bryce-b
Copy link
Member Author

bryce-b commented Aug 8, 2023

@nachoBonafonte I don't have merge permissions, could you merge this?

@nachoBonafonte nachoBonafonte merged commit 869dc5a into main Aug 8, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants