Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics refactor #432

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Metrics refactor #432

merged 4 commits into from
Jul 6, 2023

Conversation

bryce-b
Copy link
Member

@bryce-b bryce-b commented Jun 26, 2023

- changed builder structs to classes
- removed unused classes
- filled out noops
- tests

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: +4.92 🎉

Comparison is base (0b1a4dd) 61.26% compared to head (fcd27fd) 66.18%.

❗ Current head fcd27fd differs from pull request most recent head 16ce172. Consider uploading reports for the commit 16ce172 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   61.26%   66.18%   +4.92%     
==========================================
  Files         335      330       -5     
  Lines       14029    14042      +13     
==========================================
+ Hits         8595     9294     +699     
+ Misses       5434     4748     -686     
Impacted Files Coverage Δ
...es/OpenTelemetrySdk/Logs/LogRecordBuilderSdk.swift 100.00% <ø> (ø)
.../Metrics/Stable/DoubleCounterMeterBuilderSdk.swift 0.00% <ø> (ø)
...etrics/Stable/DoubleHistogramMeterBuilderSdk.swift 80.00% <ø> (+80.00%) ⬆️
...Metrics/Stable/DoubleUpDownCounterBuilderSdk.swift 0.00% <0.00%> (ø)
...trySdk/Metrics/Stable/DoubleUpDownCounterSdk.swift 0.00% <0.00%> (ø)
...table/Exporter/StablePeriodicMetricReaderSdk.swift 69.49% <0.00%> (+69.49%) ⬆️
...s/OpenTelemetrySdk/Metrics/Stable/Instrument.swift 0.00% <ø> (ø)
...Sdk/Metrics/Stable/InstrumentSelectorBuilder.swift 100.00% <ø> (+100.00%) ⬆️
...emetrySdk/Metrics/Stable/LongGaugeBuilderSdk.swift 0.00% <0.00%> (ø)
.../Metrics/Stable/LongHistogramMeterBuilderSdk.swift 0.00% <ø> (ø)
... and 15 more

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

- changed builder structs to classes
- removed unused classes
- filled out noops
- tests
- Corrected incorrect dealloc in StablePeriodicMetricReader
- Corrected default regex for Instrument Selector
- removed inout attribute for storage in meters, preventing in potentially unowned storage objectes.
- changed StableObservableMeasurementSdk from struct to class to prevent copy propogation.
@nachoBonafonte nachoBonafonte merged commit a9287f0 into main Jul 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants