Resolve declarative config TODOs #4394
Open
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
commented
Feb 3, 2025
| @@ -31,7 +31,7 @@ The data model itself is an abstraction with multiple built-in representations: | |||
|
|
|||
| ### Stability definition | |||
|
|
|||
| TODO: define stability guarantees and backwards compatibility | |||
| See `opentelemetry-configuration` [stability definition](https://github.com/open-telemetry/opentelemetry-configuration?tab=readme-ov-file#stability-definition). | |||
There was a problem hiding this comment.
The definition of stability is still being proposed reviewed here, but we know that the definition will live in opentelemetry-configuration.
jack-berg
commented
Feb 3, 2025
|
|
||
| TODO: deprecate env vars which are not | ||
| compatible ([#3967](https://github.com/open-telemetry/opentelemetry-specification/issues/3967)) | ||
| TODO: provide solution for platforms to contribute to | ||
| configure ([#3966](https://github.com/open-telemetry/opentelemetry-specification/issues/3966)) |
There was a problem hiding this comment.
This issue is resolved.
reyang
approved these changes
Feb 3, 2025
MrAlias
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4374.
Remove a couple of TODOs which already have resolutions.