-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate exception.escaped
attribute, update exception example
#4368
Deprecate exception.escaped
attribute, update exception example
#4368
Conversation
847e1a0
to
413eed9
Compare
exception.escaped
attribute, update exception exampleexception.escaped
attribute, update exception example
b8d5071
to
2169716
Compare
Overall LGTM, but we should add this note from the semconv repo:
Mostly because the example seems to imply this, but better be super clear IMHO. |
makes sense, @carlosalberto, updated in 0f7d54c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exception.escaped
is not used anywhere in OTel Go.
This is follow up on open-telemetry/semantic-conventions#1716 - cross signal guidance on how to record errors (and exceptions) in instrumentations.
Changes
Follow up for open-telemetry/semantic-conventions#1716
exception.escaped
attribute is not used in practice within OTel instrumentations (checked Java, .NET, JS. Python, Go, C++ and Rust including contrib repos).OTel instrumentations, in general, don't record handled exceptions, i.e. virtually all exceptions we're recording in non-native instrumentations are expected to escape span scope.
The litmus test whether to record exception on spans is whether the instrumentation is going to set span status to
ERROR
due to this exception.A way to record all sorts of exceptions is being introduced in #4333 and leverages logs along with severity that conveys how critical the exception is in more expressive way than
exception.escaped
flag.exception.escaped
? semantic-conventions#1516CHANGELOG.md
file updated for non-trivial changesspec-compliance-matrix.md
updated if necessary