Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type json indent as optional #4402

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

NN---
Copy link

@NN--- NN--- commented Jan 30, 2025

Description

Python json.dumps has optional indent parameter which is not reflected in the API.
This is not a breaking change, only the type is updated.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

No test is needed, it is only typing change.

Does This PR Require a Contrib Repo Change?

7

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@NN--- NN--- requested a review from a team as a code owner January 30, 2025 15:25
Copy link

linux-foundation-easycla bot commented Jan 30, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@aabmass
Copy link
Member

aabmass commented Jan 30, 2025

Python json.dumps has optional indent parameter which is not reflected in the API.
This is not a breaking change, only the type is updated.

@NN--- the change looks good but can you add some context? Also why would you want to pass None?

@NN---
Copy link
Author

NN--- commented Jan 30, 2025

I want to write json to file with each span on a single line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants