Switched langchain llm callbacks to use genai utils handler #3889
+421
−374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tils apis instead.
github-actions
bot
assigned
codefromthecrypt,
DylanRussell,
karthikscale3,
lzchen,
nirga and
wrisa
adityamehra
reviewed
Oct 20, 2025
| from opentelemetry.instrumentation.utils import unwrap | ||
| from opentelemetry.semconv.schemas import Schemas | ||
| from opentelemetry.trace import get_tracer | ||
| from opentelemetry.util.genai.handler import get_telemetry_handler |
There was a problem hiding this comment.
After this coupling, opentelemetry-util-genai should be added to the dependency in pyproject.toml
| __name__, | ||
| __version__, | ||
| tracer_provider, | ||
| schema_url=Schemas.V1_37_0.value, |
There was a problem hiding this comment.
Looks like the version that is being used in opentelemetry-util-genai is Schemas.V1_36_0.value. Should it be updated over there as we are downgrading?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed telemetry creation in langchain's llm callbacks and added genai utils handler.
This PR3768(merged) added llm span support in genai utils. This PR3862(not merged) is adding more attributes to llm span. The second PRs changes will be incorporated in current PR and will be moved out from draft state.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.