Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug_fix(1477): type handling in _add_sql_comment #3113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aryabharat
Copy link

Description

This PR fixes an issue with SQL comment generation, the current implementation fails when processing non-string SQL queries, particularly those from psycopg2's SQL utilities.
Modified _add_sql_comment() function to handles different SQL query types by converting incoming sql queries to strings
Preserves the original query if comment generation fails

Fixes # (issue)

#1477

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@aryabharat aryabharat requested a review from a team as a code owner December 17, 2024 17:20
Copy link

linux-foundation-easycla bot commented Dec 17, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant