kafka-python-ng: Instrument temporary fork kafka-python-ng by copying kafka-python's instrumentation #2532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a new kafka-python-ng instrumentation to instrument the new (and temporary) fork of kafka-python called kafka-python-ng (https://github.com/wbarnha/kafka-python-ng). It copies all of the instrumentation from the kafka-python instrumentation and places it in the new folder.
The old maintainer of kafka-python is no longer able to support the project and has passed the project off to a new maintainer. However, the new maintainer does not yet have access to the kafka-python namespace in pypi so cannot release a new version. See dpkp/kafka-python#2431
Since this fork looks to be semi temporary, I think its a little strange to create a whole new instrumentation for it but the issue linked above gives no timeline on when we might expect the reunification.
I originally tried to use the old instrumentation and just point it at either kafka-python or kafka-python-ng but it didn't seemed to treat comma delineated packages as ANDs instead of ORs. If there is a way to say, "this package or that package" I think that might be a better solution but I did not see any examples of it.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested locally. Same tests as the previous kafka-python instrumentation
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.