Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about schema url and schema version #605

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Dec 4, 2024

It wasn't obvious to me that schema_url requires that the last part of the URL path is the schema version number.

From the spec:

The last part of the URL path is the version number of the schema.

This PR extends the comment for each schema_url to make this crucial piece of information clear. Note there are still other relevant bits of information about schema_url that readers need to follow the link to https://opentelemetry.io/docs/specs/otel/schemas/#schema-url in order to understand. E.g. that the version follows the format MAJOR.MINOR.PATCH and more.

@reyang reyang merged commit 653d802 into open-telemetry:main Dec 10, 2024
15 checks passed
@lmolkova lmolkova mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants