Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: drop Sample.label #583

Merged
merged 4 commits into from
Sep 16, 2024
Merged

profiles: drop Sample.label #583

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd2a15f
profiles: drop Sample.label
florianl Sep 10, 2024
1f71847
Merge branch 'main' into patch-4
tigrannajaryan Sep 12, 2024
74fd626
Merge branch 'main' into patch-4
tigrannajaryan Sep 16, 2024
08f0fd9
Merge branch 'main' into patch-4
tigrannajaryan Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions opentelemetry/proto/profiles/v1experimental/pprofextended.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,16 +241,6 @@ message Sample {
// result has a list of values that is the element-wise sum of the
// lists of the originals.
repeated int64 value = 2;
// label includes additional context for this sample. It can include
// things like a thread id, allocation size, etc.
//
// NOTE: While possible, having multiple values for the same label key is
// strongly discouraged and should never be used. Most tools (e.g. pprof) do
// not have good (or any) support for multi-value labels. And an even more
// discouraged case is having a string label and a numeric label of the same
// name on a sample. Again, possible to express, but should not be used.
// [deprecated, superseded by attributes]
repeated Label label = 3;
florianl marked this conversation as resolved.
Show resolved Hide resolved
// References to attributes in Profile.attribute_table. [optional]
repeated uint64 attributes = 10;

Expand Down
Loading