fix: OTLP JSON examples #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why The example files do not follow the specification. 64 bit integers must be [string encoded](https://protobuf.dev/programming-guides/proto3/#json). # What - Fix the encoding in the examples - Add an example for log `severityNumber` to point at the enum encoding rules.
tigrannajaryan
approved these changes
Dec 15, 2023
jsuereth
approved these changes
Jan 9, 2024
bogdandrutu
approved these changes
Jan 9, 2024
VinozzZ
pushed a commit
to VinozzZ/opentelemetry-proto
that referenced
this pull request
Jun 21, 2024
# Why The example files do not follow the specification. 64 bit integers must be [string encoded](https://protobuf.dev/programming-guides/proto3/#json). # What - Fix the encoding in the examples - Add an example for log `severityNumber` to point at the enum encoding rules.
VinozzZ
pushed a commit
to VinozzZ/opentelemetry-proto
that referenced
this pull request
Jun 21, 2024
# Why The example files do not follow the specification. 64 bit integers must be [string encoded](https://protobuf.dev/programming-guides/proto3/#json). # What - Fix the encoding in the examples - Add an example for log `severityNumber` to point at the enum encoding rules.
VinozzZ
pushed a commit
to VinozzZ/opentelemetry-proto
that referenced
this pull request
Jun 21, 2024
# Why The example files do not follow the specification. 64 bit integers must be [string encoded](https://protobuf.dev/programming-guides/proto3/#json). # What - Fix the encoding in the examples - Add an example for log `severityNumber` to point at the enum encoding rules.
VinozzZ
pushed a commit
to VinozzZ/opentelemetry-proto
that referenced
this pull request
Jun 21, 2024
# Why The example files do not follow the specification. 64 bit integers must be [string encoded](https://protobuf.dev/programming-guides/proto3/#json). # What - Fix the encoding in the examples - Add an example for log `severityNumber` to point at the enum encoding rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The example files do not follow the specification. 64 bit integers must be string
encoded.
What
severityNumberto point at the enum encoding rules (to help folks with cases like these).