fix(sdk): skip absent keys in FilteredAttributeProcessor#2000
Open
jorgsowa wants to merge 1 commit into
Open
Conversation
Attributes::get() returns null for missing keys, and the raw array is stored verbatim, so allow-listed keys not present on the measurement were kept as key => null instead of being dropped. This restores behavior lost in a7a2861 when the AttributesBuilder (which treated null values as unset) was replaced with a plain array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attributes::get()returns null for missing keys, and the raw array is stored verbatim, so allow-listed keys not present on the measurement were kept askey => nullinstead of being dropped.