fix: preserve debug log level priority in Logging::level()#1991
Open
jorgsowa wants to merge 2 commits into
Open
fix: preserve debug log level priority in Logging::level()#1991jorgsowa wants to merge 2 commits into
jorgsowa wants to merge 2 commits into
Conversation
array_search returns 0 for debug (first in the LEVELS array) and false when not found; the old ?: 1 collapsed both to 1 (info), silently ignoring debug-level messages. Use !== false to distinguish the two.
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1991 +/- ##
============================================
- Coverage 68.02% 68.02% -0.01%
- Complexity 3075 3076 +1
============================================
Files 459 459
Lines 9017 9020 +3
============================================
+ Hits 6134 6136 +2
- Misses 2883 2884 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
|
@jorgsowa thanks for this. Would you be able to take a look at the failing unit test please? |
The debug data set relied on the pre-f46ff1d6 bug that collapsed debug's priority to info. With the fix, debug is correctly below the default info threshold, so set OTEL_LOG_LEVEL=debug to exercise all levels.
Author
|
@ChrisLightfootWild test adjusted. |
ChrisLightfootWild
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
array_search returns 0 for debug (first in the LEVELS array) and false when not found; the old ?: 1 collapsed both to 1 (info), silently ignoring debug-level messages. Use !== false to distinguish the two.