-
Notifications
You must be signed in to change notification settings - Fork 948
feat(opentelemetry-configuration): parse logger provider from config file #5995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…o parse-more-parameters
…o parse-more-parameters
…o parse-more-parameters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5995 +/- ##
==========================================
+ Coverage 95.01% 95.20% +0.19%
==========================================
Files 313 314 +1
Lines 8799 8865 +66
Branches 1888 1911 +23
==========================================
+ Hits 8360 8440 +80
+ Misses 439 425 -14
🚀 New features to boost your workflow:
|
|
cc @JamieDanielson just merged with main, after the tracer parser PR was merged, so this PR is ready for review and should be straight forward now 😄 |
JamieDanielson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maryliag ! I've left some questions and notes for your review.
experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-configuration/test/ConfigProvider.test.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-configuration/src/FileConfigProvider.ts
Outdated
Show resolved
Hide resolved
…rom env vars (open-telemetry#6015) Co-authored-by: Marc Pichler <[email protected]>
JamieDanielson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Parse Logger Provider