Skip to content

Conversation

@maryliag
Copy link
Contributor

@maryliag maryliag commented Oct 8, 2025

Parse Logger Provider

@maryliag maryliag requested a review from a team as a code owner October 8, 2025 18:29
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 95.45455% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.20%. Comparing base (fb6476d) to head (f4d1d0c).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ntelemetry-configuration/src/FileConfigProvider.ts 94.80% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5995      +/-   ##
==========================================
+ Coverage   95.01%   95.20%   +0.19%     
==========================================
  Files         313      314       +1     
  Lines        8799     8865      +66     
  Branches     1888     1911      +23     
==========================================
+ Hits         8360     8440      +80     
+ Misses        439      425      -14     
Files with missing lines Coverage Δ
...try-configuration/src/EnvironmentConfigProvider.ts 97.28% <100.00%> (+4.84%) ⬆️
...ntelemetry-configuration/src/models/commonModel.ts 100.00% <ø> (ø)
...ntelemetry-configuration/src/models/configModel.ts 100.00% <100.00%> (ø)
...ry-configuration/src/models/loggerProviderModel.ts 100.00% <100.00%> (ø)
...ntelemetry-configuration/src/FileConfigProvider.ts 97.07% <94.80%> (+1.80%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maryliag
Copy link
Contributor Author

cc @JamieDanielson just merged with main, after the tracer parser PR was merged, so this PR is ready for review and should be straight forward now 😄

Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maryliag ! I've left some questions and notes for your review.

Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@maryliag maryliag added this pull request to the merge queue Oct 21, 2025
Merged via the queue into open-telemetry:main with commit 10ad545 Oct 21, 2025
27 checks passed
@maryliag maryliag deleted the logger-parse branch October 21, 2025 20:31
@otelbot-js otelbot-js bot mentioned this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants