refactor(exporter-*): remove export * from ...
#5399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` /home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/exporter-trace-otlp-http/src/index.ts 20:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax /home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/exporter-trace-otlp-http/src/platform/browser/index.ts 20:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax /home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/exporter-trace-otlp-http/src/platform/index.ts 20:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax /home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/exporter-trace-otlp-http/src/platform/node/index.ts 20:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax ``` The comment say we should do this before the next "major" (minor since we are pre-1.0?) version, which means this is the right time to do it. However, I'm not sure if there is a real need/reason for that. As far as I can tell, this is still exporting exactly the same items and shouldn't cause any breakages? Ref open-telemetry#5365
``` /home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/exporter-trace-otlp-grpc/src/index.ts 20:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax ``` The comment say we should do this before the next "major" (minor since we are pre-1.0?) version, which means this is the right time to do it. However, I'm not sure if there is a real need/reason for that. As far as I can tell, this is still exporting exactly the same items and shouldn't cause any breakages? Ref open-telemetry#5365
``` /home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/src/index.ts 20:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax ``` The comment say we should do this before the next "major" (minor since we are pre-1.0?) version, which means this is the right time to do it. However, I'm not sure if there is a real need/reason for that. As far as I can tell, this is still exporting exactly the same items and shouldn't cause any breakages? Ref open-telemetry#5365
``` /home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/opentelemetry-exporter-metrics-otlp-proto/src/index.ts 20:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax ``` The comment say we should do this before the next "major" (minor since we are pre-1.0?) version, which means this is the right time to do it. However, I'm not sure if there is a real need/reason for that. As far as I can tell, this is still exporting exactly the same items and shouldn't cause any breakages? Ref open-telemetry#5365
``` /home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/exporter-logs-otlp-grpc/src/index.ts 20:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax ``` The comment say we should do this before the next "major" (minor since we are pre-1.0?) version, which means this is the right time to do it. However, I'm not sure if there is a real need/reason for that. As far as I can tell, this is still exporting exactly the same items and shouldn't cause any breakages? Ref open-telemetry#5365
25 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5399 +/- ##
=======================================
Coverage 94.63% 94.63%
=======================================
Files 318 318
Lines 8032 8032
Branches 1685 1685
=======================================
Hits 7601 7601
Misses 431 431 |
8 tasks
chancancode
changed the title
export * from ...
|
We held some of them back when we updated the other packages to avoid conflicts while I was re-structuring exporters. That's done now. We had some cases in some of these packages that we could not solve without a major refactor. The comment's intention was to ensure that we remove it before marking the package as GA, mainly as a way to ensure we don't export anything we don't intend to. Refs #4186 |
pichlermarc
approved these changes
Jan 30, 2025
pichlermarc
changed the title
export * from ...export * from ...
Merged
via the queue into
open-telemetry:main
with commit Jan 30, 2025
a04284c
14 of 15 checks passed
trentm
reviewed
Feb 5, 2025
Comment on lines
17
to
19
| /* eslint no-restricted-syntax: ["warn", "ExportAllDeclaration"] -- | ||
| * TODO: Replace wildcard export with named exports before next major version | ||
| */ |
There was a problem hiding this comment.
@chancancode A late question on this one. I assume this eslint and TODO comment could now be removed, right?
trentm
added a commit
to trentm/opentelemetry-js
that referenced
this pull request
Feb 5, 2025
This TODO was handled in open-telemetry#5399.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fix the following eslint warnings:
Ref #5365
Short description of the changes
The comment say we should do this before the next "major" (minor since we are pre-1.0?) version, which means this is the right time to do it.
However, I'm not sure if there is a real need/reason for that. As far as I can tell, this is still exporting exactly the same items and shouldn't cause any breakages?
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: