refactor(exporter-trace-otlp-http): fix eslint warnings #5398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` /home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/exporter-trace-otlp-http/src/index.ts 20:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax /home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/exporter-trace-otlp-http/src/platform/browser/index.ts 20:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax /home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/exporter-trace-otlp-http/src/platform/index.ts 20:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax /home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/exporter-trace-otlp-http/src/platform/node/index.ts 20:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax ``` The existing eslint comment wasn't working because it was in the wrong format. The comment say we should do this before the next "major" (minor since we are pre-1.0?) version, which means this is the right time to do it. However, I'm not sure if there is a real need/reason for that. As far as I can tell, this is still exporting exactly the same items and shouldn't cause any breakages?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5398 +/- ##
=======================================
Coverage 94.63% 94.63%
=======================================
Files 318 318
Lines 8032 8032
Branches 1685 1685
=======================================
Hits 7601 7601
Misses 431 431 |
25 tasks
|
There are a bunch of these across packages, closing this and consolidating those changes into a single PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fix the following eslint warnings in the exporter-trace-otlp-http package:
Ref #5365
Short description of the changes
The existing eslint comment wasn't working because it was in the wrong format.
The comment say we should do this before the next "major" (minor since we are pre-1.0?) version, which means this is the right time to do it.
However, I'm not sure if there is a real need/reason for that. As far as I can tell, this is still exporting exactly the same items and shouldn't cause any breakages?
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: