refactor(sdk-trace-web): fix eslint warning #5388
Merged
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` /home/runner/work/opentelemetry-js/opentelemetry-js/packages/opentelemetry-sdk-trace-web/src/utils.ts 52:14 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any ``` The eslint comment wasn't working because it was placed on the wrong line. However, it also wasn't necessary anymore – `keyof any` was used to obtain the union of all possible object key types – `string | number | symbol`. TypeScript now provides an alias for this in the standard libaray that gives exactly the same result. Also fixed what appears to be a TypeError on an un-annotated `let` binding, not sure why it wasn't caught by the type checker, maybe it was just missed on the version of TS we are using. Ref open-telemetry#5365
25 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5388 +/- ##
=======================================
Coverage 94.63% 94.63%
=======================================
Files 318 318
Lines 8036 8036
Branches 1685 1685
=======================================
Hits 7605 7605
Misses 431 431 |
Merged
via the queue into
open-telemetry:main
with commit Jan 29, 2025
682ab65
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Ref #5365
Short description of the changes
The eslint comment wasn't working because it was placed on the wrong line. However, it also wasn't necessary anymore –
keyof anywas used to obtain the union of all possible object key types –string | number | symbol. TypeScript now provides an alias for this in the standard libaray that gives exactly the same result.Also fixed what appears to be a TypeError on an un-annotated
letbinding, not sure why it wasn't caught by the type checker, maybe it was just missed on the version of TS we are using.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: