refactor(sdk-trace-node): fix eslint warning #5387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` /home/runner/work/opentelemetry-js/opentelemetry-js/packages/opentelemetry-sdk-trace-node/test/registration.test.ts 30:61 warning Don't use `Function` as a type @typescript-eslint/ban-types ``` Here we are looking for a `AnyConstructor` type, and `Function` is a close enough approximation that exists in the standard library. The potential foot gun of _calling_ the function resulting in an `any` value still exists, but this is a small function used in tests only, so that's probably acceptable. Ref open-telemetry#5365
25 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5387 +/- ##
=======================================
Coverage 94.63% 94.63%
=======================================
Files 318 318
Lines 8036 8036
Branches 1685 1685
=======================================
Hits 7605 7605
Misses 431 431 |
pichlermarc
approved these changes
Jan 29, 2025
Merged
via the queue into
open-telemetry:main
with commit Jan 29, 2025
2759d73
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fix the following eslint warning:
Ref #5365
Short description of the changes
Here we are looking for a
AnyConstructortype, andFunctionis a close enough approximation that exists in the standard library.The potential foot gun of calling the function resulting in an
anyvalue still exists, but this is a small function used in tests only, so that's probably acceptable.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: