Merge branch 'main' into tm-semconv-1.29.0

CHANGELOG.md

@@ -26,6 +26,12 @@ For semantic convention package changes, see the [semconv CHANGELOG](packages/se
 * refactor(sdk-trace-base)!: remove `new Span` constructor in favor of `Tracer.startSpan` API [#5048](https://github.com/open-telemetry/opentelemetry-js/pull/5048) @david-luna
 * refactor(sdk-trace-base)!: remove `BasicTracerProvider.addSpanProcessor` API in favor of constructor options. [#5134](https://github.com/open-telemetry/opentelemetry-js/pull/5134) @david-luna
 * refactor(sdk-trace-base)!: make `resource` property private in `BasicTracerProvider` and remove `getActiveSpanProcessor` API. [#5192](https://github.com/open-telemetry/opentelemetry-js/pull/5192) @david-luna
+* feat(sdk-trace)!: remove ability to have BasicTracerProvider instantiate exporters [#5239](https://github.com/open-telemetry/opentelemetry-js/pull/5239) @pichlermarc
+  * When extending `BasicTracerProvider`, the class offered multiple methods to facilitate the creation of exporters and auto-pairing with `SpanProcessor`s.
+    * This functionality has been removed - users may now pass `SpanProcessor`s to the base class constructor when extending
+    * (user-facing): `_registeredExporters` has been removed
+    * (user-facing): `_getSpanExporter` has been removed
+    * (user-facing): `_buildExporterFromEnv` has been removed
 * feat(core)!: remove deprecated `IdGenerator` and `RandomIdGenerator` [#5309](https://github.com/open-telemetry/opentelemetry-js/pull/5309) @pichlermarc
 * feat(core)!: remove deprecated type `InstrumentationLibrary` [#5308](https://github.com/open-telemetry/opentelemetry-js/pull/5308) @pichlermarc
   * (user-facing): please use equivalent type `InstrumentationScope` instead

experimental/CHANGELOG.md

@@ -16,6 +16,8 @@ All notable changes to experimental packages in this project will be documented
 
 ### :rocket: (Enhancement)
 
+* feat(instrumentation): re-export initialize function from import-in-the-middle [#5123](https://github.com/open-telemetry/opentelemetry-js/pull/5123)
+
 ### :bug: (Bug Fix)
 
 * fix(exporter-metrics-otlp-http): browser OTLPMetricExporter was not passing config to OTLPMetricExporterBase super class [#5331](https://github.com/open-telemetry/opentelemetry-js/pull/5331) @trentm

experimental/packages/opentelemetry-instrumentation/hook.mjs

@@ -20,9 +20,10 @@
 // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2021 Datadog, Inc.
 
 import {
+  initialize,
   load,
   resolve,
   getFormat,
   getSource,
 } from 'import-in-the-middle/hook.mjs';
-export { load, resolve, getFormat, getSource };
+export { initialize, load, resolve, getFormat, getSource };

experimental/packages/opentelemetry-sdk-node/src/sdk.ts

@@ -363,7 +363,6 @@ export class NodeSDK {
       ? this._tracerProviderConfig.spanProcessors
       : getSpanProcessorsFromEnv();
 
-    // If the Provider is configured with Env Exporters, we need to check if the SDK had any manual configurations and set them here
     this._tracerProvider = new NodeTracerProvider({
       ...this._configuration,
       resource: this._resource,

experimental/packages/opentelemetry-sdk-node/test/sdk.test.ts

@@ -1465,7 +1465,7 @@ describe('setup exporter from env', () => {
     await sdk.shutdown();
   });
 
-  it('should use noop span processor when user sets env exporter to none', async () => {
+  it('should use empty span processor when user sets env exporter to none', async () => {
     env.OTEL_TRACES_EXPORTER = 'none';
     const sdk = new NodeSDK();
     sdk.start();
@@ -1478,8 +1478,7 @@ describe('setup exporter from env', () => {
 
     const listOfProcessors = getSdkSpanProcessors(sdk);
 
-    assert(listOfProcessors.length === 1);
-    assert(listOfProcessors[0] instanceof NoopSpanProcessor);
+    assert.strictEqual(listOfProcessors.length, 0);
     delete env.OTEL_TRACES_EXPORTER;
     await sdk.shutdown();
   });