Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing telemetry in mysql2 when importing only promise API #2662

Merged
merged 5 commits into from
Jan 21, 2025

Merge branch 'main' into fix-otel-js-contrib-2590

7182d08
Select commit
Loading
Failed to load commit list.
Merged

fix: missing telemetry in mysql2 when importing only promise API #2662

Merge branch 'main' into fix-otel-js-contrib-2590
7182d08
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 21, 2025 in 0s

90.96% (+0.00%) compared to 5f214eb

View this Pull Request on Codecov

90.96% (+0.00%) compared to 5f214eb

Details

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.96%. Comparing base (5f214eb) to head (7182d08).

Files with missing lines Patch % Lines
...etry-instrumentation-mysql2/src/instrumentation.ts 93.10% 2 Missing ⚠️
.../opentelemetry-instrumentation-mysql2/src/utils.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2662   +/-   ##
=======================================
  Coverage   90.95%   90.96%           
=======================================
  Files         172      172           
  Lines        8119     8137   +18     
  Branches     1646     1649    +3     
=======================================
+ Hits         7385     7402   +17     
- Misses        734      735    +1     
Files with missing lines Coverage Δ
.../opentelemetry-instrumentation-mysql2/src/utils.ts 91.30% <50.00%> (-1.88%) ⬇️
...etry-instrumentation-mysql2/src/instrumentation.ts 95.60% <93.10%> (+0.93%) ⬆️