feat(instrumentation-mongodb): Lighten scrubbed data #2653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves: #2281
Resolves: #2516
_scrubStatement
scrubs all data, including binary data, and with large datasets it can create performance issues.mongoose
. (eg:__parentArray
)Short description of the changes
This PR updates the behaviour as described in @trentm's comment.
10
for recursion inside deeply nested objects. Please let me know if that needs to be configurable.Buffer
andUint8Array
data while scrubbing.mongoose
-added keys, which are marked asnon-enumerable
from mongoose versions after5.13.14
.Note: I was not able to test with
mongoose
versions under5.13.14
in the unit tests due to type mismatches between[email protected]
andmongoose < 5.13.14
devDependencies
.