-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(instrumentation-knex): Support better-sqlite3 errors #2650
Open
deejay1
wants to merge
10
commits into
open-telemetry:main
Choose a base branch
from
deejay1:knex-sqlite3-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+176
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deejay1
changed the title
Knex sqlite3 v2
fix(instrumentation-knex): Support better-sqlite3 errors
Jan 16, 2025
github-actions
bot
added
pkg:instrumentation-knex
pkg-status:unmaintained
This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
labels
Jan 16, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2650 +/- ##
==========================================
- Coverage 90.84% 90.83% -0.01%
==========================================
Files 172 172
Lines 8103 8100 -3
Branches 1646 1646
==========================================
- Hits 7361 7358 -3
Misses 742 742
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
pkg:instrumentation-knex
pkg-status:unmaintained
This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #2297
Short description of the changes
Make sure better-sqlite3 is supported by not assuming how the error constructor is set up. Adds test accordingly.
This is a rebase of #2298 by @AbhiPrasad with included review changes.