-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-sdk)!: drop support for AWS SDK for JavaScript v2 #2623
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2623 +/- ##
==========================================
- Coverage 90.95% 89.31% -1.65%
==========================================
Files 172 172
Lines 8137 8046 -91
Branches 1649 1625 -24
==========================================
- Hits 7401 7186 -215
- Misses 736 860 +124
|
43d7ee6
to
07d9c02
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1e7dd92
to
fd36945
Compare
This comment was marked as outdated.
This comment was marked as outdated.
fd36945
to
74259dc
Compare
74259dc
to
293aec2
Compare
Thank you @pichlermarc. I've rebased the changes. The CI is failing though for the path which isn't updated 1) MessageAttributes
injectPropagationContext
should inject context if there are available attributes:
Error: expect(received).toBeGreaterThan(expected) Test code which fails: Line 84 in 6b4e532
Execution https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/12792793464/job/35664659517?pr=2623 I confirmed when debugging that Line 81 in 6b4e532
|
}); | ||
}); | ||
|
||
describe('SNS - v3', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it tested v3 - did you mean to delete these tests? 🤔
@trivikr oh, looks like the lint step is failing. |
a1e15a1
to
18b31e6
Compare
Which problem is this PR solving?
Short description of the changes