Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detector-aws): add more lambda semconv attributes #2589

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

garysassano
Copy link
Contributor

@garysassano garysassano commented Dec 6, 2024

Which problem is this PR solving?

Adding extra attributes: aws.log.group.names, faas.instance, faas.max_memory

Short description of the changes

See above.

@garysassano garysassano requested a review from a team as a code owner December 6, 2024 01:08
Copy link

linux-foundation-easycla bot commented Dec 6, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot requested a review from jj22ee December 6, 2024 01:08
@garysassano garysassano changed the title update aws lambda detector fix(detector-aws): update aws lambda detector Dec 6, 2024
@garysassano garysassano changed the title fix(detector-aws): update aws lambda detector feat(detector-aws): add attributes to aws lambda detector Jan 17, 2025
@garysassano garysassano force-pushed the upd-aws-detector branch 3 times, most recently from dfa4c57 to 766c412 Compare January 17, 2025 13:44
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.97%. Comparing base (4f1e605) to head (5e7741b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2589   +/-   ##
=======================================
  Coverage   90.96%   90.97%           
=======================================
  Files         172      172           
  Lines        8137     8141    +4     
  Branches     1649     1648    -1     
=======================================
+ Hits         7402     7406    +4     
  Misses        735      735           
Files with missing lines Coverage Δ
...etector-aws/src/detectors/AwsLambdaDetectorSync.ts 100.00% <100.00%> (ø)
...opentelemetry-resource-detector-aws/src/semconv.ts 100.00% <100.00%> (ø)

@garysassano garysassano force-pushed the upd-aws-detector branch 2 times, most recently from 80da25a to ff814dc Compare January 21, 2025 00:25
@garysassano garysassano changed the title feat(detector-aws): add attributes to aws lambda detector feat(detector-aws): add semconv attributes Jan 21, 2025
@garysassano garysassano changed the title feat(detector-aws): add semconv attributes feat(detector-aws): add more lambda semconv attributes Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants