-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(detector-aws): add more lambda semconv attributes #2589
Open
garysassano
wants to merge
10
commits into
open-telemetry:main
Choose a base branch
from
garysassano:upd-aws-detector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garysassano
changed the title
update aws lambda detector
fix(detector-aws): update aws lambda detector
Dec 6, 2024
jj22ee
reviewed
Dec 10, 2024
detectors/node/opentelemetry-resource-detector-aws/src/detectors/AwsLambdaDetectorSync.ts
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-aws/src/detectors/AwsLambdaDetectorSync.ts
Outdated
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-aws/src/detectors/AwsLambdaDetectorSync.ts
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-aws/src/detectors/AwsLambdaDetectorSync.ts
Show resolved
Hide resolved
garysassano
changed the title
fix(detector-aws): update aws lambda detector
feat(detector-aws): add attributes to aws lambda detector
Jan 17, 2025
garysassano
force-pushed
the
upd-aws-detector
branch
3 times, most recently
from
January 17, 2025 13:44
dfa4c57
to
766c412
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2589 +/- ##
=======================================
Coverage 90.96% 90.97%
=======================================
Files 172 172
Lines 8137 8141 +4
Branches 1649 1648 -1
=======================================
+ Hits 7402 7406 +4
Misses 735 735
|
garysassano
force-pushed
the
upd-aws-detector
branch
9 times, most recently
from
January 17, 2025 14:42
fed273c
to
85c7bf0
Compare
garysassano
force-pushed
the
upd-aws-detector
branch
from
January 17, 2025 16:16
84a0b41
to
e3923f3
Compare
garysassano
force-pushed
the
upd-aws-detector
branch
2 times, most recently
from
January 21, 2025 00:25
80da25a
to
ff814dc
Compare
garysassano
changed the title
feat(detector-aws): add attributes to aws lambda detector
feat(detector-aws): add semconv attributes
Jan 21, 2025
garysassano
changed the title
feat(detector-aws): add semconv attributes
feat(detector-aws): add more lambda semconv attributes
Jan 21, 2025
garysassano
force-pushed
the
upd-aws-detector
branch
from
January 21, 2025 00:36
ca2fcf3
to
77c19b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Adding extra attributes:
aws.log.group.names
,faas.instance
,faas.max_memory
Short description of the changes
See above.