feat(instrumentation-aws-lambda): In AWS Lambda instrumentation, extend invocation span start time back to Lambda environment startup time on coldstart #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2533 +/- ##
=======================================
Coverage 90.75% 90.75%
=======================================
Files 169 169
Lines 8018 8019 +1
Branches 1632 1633 +1
=======================================
+ Hits 7277 7278 +1
Misses 741 741
|
… to Lambda environment startup time on coldstart
serkan-ozal
force-pushed
the
feat/instrumentation/aws-lambda/extend-start-time-back-to-startup-time-on-coldstart
branch
from
ebc9ea8 to
39cf372
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Currently, AWS Lambda instrumentation doesn't take Lambda startup time into account while calculating invocation span start time on coldstarts. So, this behavior leads to reporting dramatically incorrect invocation span duration.
Short description of the changes
In this PR, Lambda environment start time is used as invocation span start time on coldstarts, so reported invocation span time also includes initialization time too.