Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update the express example #2532

Merged
merged 12 commits into from
Nov 27, 2024
Merged

Conversation

sp6370
Copy link
Contributor

@sp6370 sp6370 commented Nov 16, 2024

Which problem is this PR solving?

Short description of the changes

  • Nukes the Zipkin usage and usage of Jaeger Otel Library
  • Added a fix for the code compilation failing
  • Update the otel dependencies to latest version
  • Also fixed the deprecations for the semantic conventions

@sp6370 sp6370 requested a review from a team as a code owner November 16, 2024 00:42
@sp6370
Copy link
Contributor Author

sp6370 commented Nov 16, 2024

@trentm Thanks a lot for your help and feedback on the PR. Looking forward to the code review! 😄

@sp6370 sp6370 changed the title Updates to the express example. chore: Updates to the express example Nov 16, 2024
@sp6370 sp6370 changed the title chore: Updates to the express example chore: Update the express example Nov 16, 2024
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes. Looking good, thanks.

examples/express/README.md Outdated Show resolved Hide resolved
examples/express/README.md Outdated Show resolved Hide resolved
examples/express/package.json Outdated Show resolved Hide resolved
examples/express/src/tracer.ts Outdated Show resolved Hide resolved
examples/express/src/tracer.ts Outdated Show resolved Hide resolved
examples/express/README.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (6ee7e7f) to head (1725502).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2532   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         169      169           
  Lines        8018     8018           
  Branches     1632     1632           
=======================================
  Hits         7277     7277           
  Misses        741      741           

@pichlermarc pichlermarc added pkg:instrumentation-express documentation Improvements or additions to documentation labels Nov 21, 2024
@sp6370
Copy link
Contributor Author

sp6370 commented Nov 24, 2024

@trentm Thanks for the awesome code review! 😄

Definitely learned a lot from it!

LMK if anymore changes are needed.

Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one lint fix suggestion below. Otherwise, LGTM. Thanks!

examples/express/README.md Show resolved Hide resolved
@JamieDanielson JamieDanielson merged commit d7773a2 into open-telemetry:main Nov 27, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pkg:instrumentation-express
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants