-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update the express example #2532
Conversation
Required to get the code compiled.
@trentm Thanks a lot for your help and feedback on the PR. Looking forward to the code review! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes. Looking good, thanks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2532 +/- ##
=======================================
Coverage 90.75% 90.75%
=======================================
Files 169 169
Lines 8018 8018
Branches 1632 1632
=======================================
Hits 7277 7277
Misses 741 741 |
Co-authored-by: Trent Mick <[email protected]>
Signed-off-by: Sudhanshu Pandey <[email protected]>
@trentm Thanks for the awesome code review! 😄 Definitely learned a lot from it! LMK if anymore changes are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one lint fix suggestion below. Otherwise, LGTM. Thanks!
Which problem is this PR solving?
Short description of the changes