Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detector-aws): Get ECS Container ID from metadata #2509

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iancward
Copy link

Which problem is this PR solving?

Short description of the changes

  • Get ECS container ID from ECS metadata. This will get the correct value whether running in ECS Fargate or ECS on EC2

@iancward iancward requested a review from a team as a code owner October 28, 2024 20:19
Copy link

linux-foundation-easycla bot commented Oct 28, 2024

CLA Not Signed

Which prolbem is this PR solving?

- The AWS ECS Resource detector is munging the container ID when running
  in AWS ECS Fargate

ref: open-telemetry#2032

Short description of the changes

- Get ECS container ID from ECS metadata. This will get the correct
  value whether running in ECS Fargate or ECS on EC2
@iancward iancward force-pushed the ecs_fargate_container_id branch from ed6a61a to 5f48d6a Compare October 28, 2024 20:24
@iancward iancward changed the title fix(detector-aws) - Get ECS Container ID from metadata fix(detector-aws): Get ECS Container ID from metadata Oct 28, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (9a20e15) to head (5f48d6a).

Files with missing lines Patch % Lines
...e-detector-aws/src/detectors/AwsEcsDetectorSync.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2509      +/-   ##
==========================================
+ Coverage   90.85%   91.88%   +1.02%     
==========================================
  Files         159       52     -107     
  Lines        7853     2636    -5217     
  Branches     1622      477    -1145     
==========================================
- Hits         7135     2422    -4713     
+ Misses        718      214     -504     
Files with missing lines Coverage Δ
...e-detector-aws/src/detectors/AwsEcsDetectorSync.ts 32.22% <71.42%> (-64.90%) ⬇️

... and 107 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant