-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(koa): Adds support to ignore a span by its layer name #2028
Open
MrFabio
wants to merge
1
commit into
open-telemetry:main
Choose a base branch
from
MrFabio:feature/koa-ignore
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+190
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MrFabio
force-pushed
the
feature/koa-ignore
branch
3 times, most recently
from
March 26, 2024 22:16
4623e18
to
47bed61
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
2 times, most recently
from
April 2, 2024 13:49
f41b872
to
a5b3a6e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2028 +/- ##
==========================================
+ Coverage 90.78% 90.80% +0.01%
==========================================
Files 169 169
Lines 8055 8077 +22
Branches 1643 1649 +6
==========================================
+ Hits 7313 7334 +21
- Misses 742 743 +1
|
MrFabio
force-pushed
the
feature/koa-ignore
branch
8 times, most recently
from
April 6, 2024 13:55
882914e
to
57512e3
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
from
April 10, 2024 09:44
57512e3
to
d5e6c1d
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
from
April 18, 2024 18:35
d5e6c1d
to
5cb51b8
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
2 times, most recently
from
May 9, 2024 14:11
8e3b4df
to
fe52615
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
4 times, most recently
from
May 21, 2024 21:38
f0e8dd2
to
e2b7711
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
2 times, most recently
from
May 24, 2024 10:31
ff73355
to
1dce93d
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
2 times, most recently
from
June 4, 2024 15:02
882121f
to
f7565e7
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
from
June 8, 2024 13:22
f7565e7
to
8dfc847
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
4 times, most recently
from
October 18, 2024 13:14
7c75702
to
791e23f
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
from
October 22, 2024 09:29
791e23f
to
35e39f8
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
3 times, most recently
from
November 4, 2024 12:20
7d78ab1
to
2bf85a9
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
from
November 5, 2024 22:57
2bf85a9
to
b113855
Compare
trentm
reviewed
Nov 7, 2024
MrFabio
force-pushed
the
feature/koa-ignore
branch
3 times, most recently
from
November 8, 2024 17:21
accecb4
to
b49bd40
Compare
Updated ✅ |
trentm
requested changes
Nov 8, 2024
MrFabio
force-pushed
the
feature/koa-ignore
branch
2 times, most recently
from
November 8, 2024 23:52
ff713f3
to
f7f30e3
Compare
trentm
reviewed
Nov 9, 2024
plugins/node/opentelemetry-instrumentation-koa/test/utils.test.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-koa/test/utils.test.ts
Outdated
Show resolved
Hide resolved
MrFabio
force-pushed
the
feature/koa-ignore
branch
2 times, most recently
from
November 9, 2024 01:43
b3e927e
to
30a395f
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
3 times, most recently
from
November 26, 2024 14:23
520fa6b
to
3b00e01
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
3 times, most recently
from
December 2, 2024 22:43
c9904e4
to
7f02777
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
2 times, most recently
from
December 11, 2024 10:05
76c8ae5
to
c5b8964
Compare
MrFabio
force-pushed
the
feature/koa-ignore
branch
from
December 17, 2024 18:11
c5b8964
to
66649b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg:instrumentation-koa
pkg-status:unmaintained:autoclose-scheduled
pkg-status:unmaintained
This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
ignoreLayersName
option to instrumentation constructor config to allow layers to be ignored by its name.ignoreLayersType
config, this new one will run after this check.Short description of the changes
KoaInstrumentationConfig
withignoreLayersName
which is an array ofstring
(layer names):isLayerNameIgnored
to check if a layer should be ignored by the name_patchLayer
to check if the layer is ignored by the config