make extended tracer easier to use #6943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6943 +/- ##
============================================
- Coverage 89.95% 89.94% -0.01%
- Complexity 6635 6636 +1
============================================
Files 745 745
Lines 20010 20010
Branches 1962 1962
============================================
- Hits 17999 17998 -1
Misses 1415 1415
- Partials 596 597 +1 ☔ View full report in Codecov by Sentry. |
|
@jack-berg please check |
|
up to @jack-berg, but I'd suggest landing #6944 first without adding any new complications |
|
What do you think about adding a sample of usage in ExtendedTraceApiUsageTest ? |
good idea - done |
jack-berg
reviewed
Jan 13, 2025
| @@ -53,6 +53,10 @@ static SdkTracer create( | |||
| : new SdkTracer(sharedState, instrumentationScopeInfo, tracerConfig); | |||
| } | |||
|
|
|||
| /** | |||
| * Note that {@link ExtendedSdkTracer#spanBuilder(String)} calls this and depends on it returning | |||
| * {@link ExtendedSdkTracer} in all cases when the incubator is present. | |||
There was a problem hiding this comment.
Merged main, and added some additional tests to confirm this.
jack-berg
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.