Allow explicit timestamps for Span start/end. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosalberto
requested review from
bogdandrutu,
SergeyKanzhelev and
yurishkuro
as code owners
|
Addresses #24 One thing that that mentioned was that OT uses microseconds - which might not be the case for this new API ;) |
|
FWIW, I am strongly in favor of NOT using micros. I would rather see something like |
+1 Why are there 34 files in this PR? Doesn't seem to match the title. |
|
Should this be closed because of #43? |
|
Closing this as I believe current decision is to use |
jkwatson
pushed a commit
that referenced
this pull request
Jul 30, 2020
* Implemented TraceConfigZ zPage (#22) * Added link to index zpage * Used AutoValue for TableRow classes * Changed wording of HTML content * Changed Builder to interface, fixed build issues * Removed tableRow classes, added omitEmpty in parseQueryMap * Added test for invalid inputs * Changed to use illegalArgumentException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.