Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve the issue of failing to retrieve attachments in dubbo 2.7.6 and 2.7.7 #12982

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Resolve the issue of failing to retrieve attachments in dubbo 2.7.6 and 2.7.7 #12982

wants to merge 3 commits into from

Conversation

steverao
Copy link
Contributor

Resolves #12978

@steverao steverao changed the title Resolve the issue of failing to retrieve attachments in dubbo 2.7.6+ Resolve the issue of failing to retrieve attachments in dubbo 2.7.6 and 2.7.7 Jan 2, 2025
steverao
steverao commented Jan 3, 2025
View reviewed changes
...gure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboHeadersGetter.java
public Iterable<String> keys(DubboRequest request) {
return request.invocation().getAttachments().keySet();
RpcInvocation invocation = request.invocation();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @laurit, is it necessary to add unit test here? I don't seem to have found any related test in current codebase, do you have any suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is a compatibility problem of DubboHeadersGetter#keys in Dubbo 2.7.6 and 2.7.7
1 participant
@steverao