Convert ratpack 1.7 tests from groovy to java #12980
Draft
+984
−754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Jan 2, 2025
| .addSpanProcessor(SimpleSpanProcessor.create(spanExporter)) | ||
| .build(); | ||
|
|
||
| protected OpenTelemetry openTelemetry = |
There was a problem hiding this comment.
Did you consider modifying these tests to use InstrumentationExtension so you wouldn't need to create OpenTelemetry instance yourself and could use waitAndAssertTraces
There was a problem hiding this comment.
i had incorrectly assumed these were written this way intentionally. I will work on refactoring them to follow the same conventions used elsewhere
laurit
reviewed
Jan 2, 2025
Comment on lines
+34
to
+51
| Context parentContext = Context.current(); | ||
| Span span = tracer.spanBuilder("a-span").setParent(parentContext).startSpan(); | ||
|
|
||
| Context otelContext = parentContext.with(span); | ||
| try (Scope scope = otelContext.makeCurrent()) { | ||
| Execution.current().add(Context.class, otelContext); | ||
| HttpClient httpClient = event.getRegistry().get(HttpClient.class); | ||
| httpClient | ||
| .get(new URI(url)) | ||
| .flatMap(response -> httpClient.get(new URI(url))) | ||
| .then( | ||
| response -> { | ||
| span.end(); | ||
| latch.countDown(); | ||
| }); | ||
| } catch (URISyntaxException e) { | ||
| throw new RuntimeException(e); | ||
| } |
There was a problem hiding this comment.
If this part is identical in both BarService and BarForkService is could be shared somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7195