-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make servlet3 + spring webmvc + jaxrs 2.0 indy compatible #12432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainJuge
changed the title
make servlet3 indy compatible
make servlet3 + spring webmvc indy compatible
Oct 10, 2024
SylvainJuge
commented
Oct 14, 2024
...telemetry/javaagent/instrumentation/springweb/v3_1/WebApplicationContextInstrumentation.java
Outdated
Show resolved
Hide resolved
…nstrumentation into indy-servlet3
…nstrumentation into indy-servlet3
…nstrumentation into indy-servlet3
SylvainJuge
commented
Oct 29, 2024
...telemetry/javaagent/instrumentation/spring/webmvc/v3_1/DispatcherServletInstrumentation.java
Outdated
Show resolved
Hide resolved
...telemetry/javaagent/instrumentation/spring/webmvc/v6_0/DispatcherServletInstrumentation.java
Outdated
Show resolved
Hide resolved
SylvainJuge
changed the title
make servlet3 + spring webmvc indy compatible
make servlet3 + spring webmvc + jaxrs 2.0 indy compatible
Oct 29, 2024
…nstrumentation into indy-servlet3
LikeTheSalad
approved these changes
Nov 5, 2024
JonasKunz
approved these changes
Nov 5, 2024
...telemetry/javaagent/instrumentation/spring/webmvc/v3_1/DispatcherServletInstrumentation.java
Outdated
Show resolved
Hide resolved
...main/java/io/opentelemetry/javaagent/instrumentation/grails/GrailsInstrumentationModule.java
Outdated
Show resolved
Hide resolved
…nstrumentation into indy-servlet3
…nstrumentation into indy-servlet3
…nstrumentation into indy-servlet3
…nstrumentation into indy-servlet3
…nstrumentation into indy-servlet3
…nstrumentation into indy-servlet3
JonasKunz
approved these changes
Nov 21, 2024
jackshirazi
approved these changes
Nov 21, 2024
…nstrumentation into indy-servlet3
laurit
reviewed
Nov 27, 2024
javaagent-bootstrap/src/main/java/io/opentelemetry/javaagent/bootstrap/IndyProxy.java
Outdated
Show resolved
Hide resolved
laurit
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #11457
Introduces
IndyProxy
interface for the classes that are injected into instrumented classes classloader which allows to transparently unwrap the proxy delegate when needed withIndyProxyHelper
. This interface and its only method is hidden from the reflection API.