Read file lines in the system default charset #12419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure that Files.lines(Path) reads filesystem files in the charset of the underlying operating system and not UTF-8. Signed-off-by: Alex Brown <[email protected]>
|
jeanbisutti
approved these changes
Oct 9, 2024
|
Thank you @SoftlySplinter Could you please follow these instructions: #12419 (comment) |
|
Thanks @jeanbisutti, I'm working on getting approval internally. |
|
@SoftlySplinter is this PR still relevant? Could you provide a sample line from |
laurit
added
the
needs author feedback
|
This has been automatically marked as stale because it has been marked as needing author feedback and has not had any activity for 7 days. It will be closed automatically if there is no response from the author within 7 additional days from this comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12418
Ensure that Files.lines(Path) reads filesystem files in the charset of the underlying operating system and not UTF-8.