[demo] - fix grafana demo dashboard #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Tessier <[email protected]>
rogercoll
approved these changes
Jul 25, 2024
| @@ -431,7 +438,7 @@ | |||
| }, | |||
| "showHeader": true | |||
| }, | |||
| "pluginVersion": "10.1.2", | |||
| "pluginVersion": "10.4.3", | |||
There was a problem hiding this comment.
Should we pin the Grafana image version in the Chart values? Noticed that we are specifying a different version that the one being used
There was a problem hiding this comment.
This dashboard is emitted by Grafana when you export it as JSON. That version is set by Grafana itself. We don't explicitly do it.
There was a problem hiding this comment.
And the Grafana version from where the dashboard was exported was 10.1.2? (The one being deployed by the Chart)
TylerHelmuth
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the fixes from this PR in the Demo repo