Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to make tag.Map threadsafe. #89

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Try to make tag.Map threadsafe. #89

merged 1 commit into from
Aug 23, 2019

Commits on Aug 23, 2019

  1. Make tag.Map a concrete type. 

    This is to make tag.Map an immutable type, so it is safe to use
concurrently. The safety is not yet fully achieved because of the
functions returning contents of the map (Value and Foreach). The
functions give callers an access to core.Value objects, which contain
a byte slice, which has pointer like semantics. So to avoid accidental
changes, we will need to copy the value if it is of BYTES type.

Fixes open-telemetry#59
    @krnowak
    krnowak committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    fc8c10e View commit details
    Browse the repository at this point in the history