Remove experimental/streaming globals, add streaming example #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
bogdandrutu,
pjanotti,
rghetia,
sjkaris and
tedsuo
as code owners
|
LGTM |
rghetia
approved these changes
Sep 21, 2019
krnowak
reviewed
Sep 21, 2019
|
And one more - please add |
|
rebase to include #139 and then run make circle-ci again to update the go.mod/go.sum files. |
6 tasks
hstan
referenced
this pull request
in hstan/opentelemetry-go
Oct 15, 2020
#135) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rghetia this is a cleanup in
experimental/streamingwhich is a first step towards the work on global initialization in RFC 0005 and the work on globals in jmacd#3.The updates in
README.mdshould be paired with your updates inexample/http. Then, I'd likeREADME.mdto eventually model after the Python README:https://github.com/open-telemetry/opentelemetry-python/blob/master/README.md