HTTP Semconv migration Part1 Server - v1.20.0 support #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Metrics Placeholders
Added changelog.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5333 +/- ##
=======================================
+ Coverage 62.1% 62.3% +0.1%
=======================================
Files 186 189 +3
Lines 11537 11575 +38
=======================================
+ Hits 7176 7219 +43
+ Misses 4149 4146 -3
+ Partials 212 210 -2
|
MrAlias
reviewed
Mar 29, 2024
instrumentation/net/http/otelhttp/internal/semconv/v1.20.0_test.go
Outdated
Show resolved
Hide resolved
instrumentation/net/http/otelhttp/internal/semconvutil/httpconv_benchmark_test.go
Outdated
Show resolved
Hide resolved
instrumentation/net/http/otelhttp/internal/semconv/v1.20.0_test.go
Outdated
Show resolved
Hide resolved
|
Please address the lint failures. |
MadVikingGod
added
the
Skip Changelog
MrAlias
reviewed
Mar 29, 2024
instrumentation/net/http/otelhttp/internal/semconv/v1.20.0_test.go
Outdated
Show resolved
Hide resolved
dashpole
reviewed
Apr 1, 2024
instrumentation/net/http/otelhttp/internal/semconv/httpconv_benchmark_test.go
Outdated
Show resolved
Hide resolved
Removed benchmark Updated license header to SPDX format Restored splitHostPort Test
pellared
reviewed
Apr 3, 2024
instrumentation/net/http/otelhttp/internal/semconv/httpconv_benchmark_test.go
Outdated
Show resolved
Hide resolved
instrumentation/net/http/otelhttp/internal/semconv/httpconv_benchmark_test.go
Outdated
Show resolved
Hide resolved
dashpole
approved these changes
Apr 3, 2024
Signed-off-by: Aaron Clawson <[email protected]>
MrAlias
approved these changes
Apr 4, 2024
dmathieu
approved these changes
Apr 5, 2024
|
Side note, please do not wait on my review. |
4 tasks
scorpionknifes
pushed a commit
to scorpionknifes/opentelemetry-go-contrib
that referenced
this pull request
Apr 24, 2024
…#5333) * added interface around semconvutil --------- Signed-off-by: Aaron Clawson <[email protected]>
scorpionknifes
pushed a commit
to scorpionknifes/opentelemetry-go-contrib
that referenced
this pull request
Apr 24, 2024
…#5333) * added interface around semconvutil --------- Signed-off-by: Aaron Clawson <[email protected]>
krim
reviewed
Aug 30, 2024
| // ServerStatus returns a span status code and message for an HTTP status code | ||
| // value returned by a server. Status codes in the 400-499 range are not | ||
| // returned as errors. | ||
| func ServerStatus(code int) (codes.Code, string) { |
There was a problem hiding this comment.
@MadVikingGod Could you explain why we cannot use codes.Ok for statuses in the range of 200..399, or at least for 2xx?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an absctraction layer to the semconv of otlehttp. This is to enable compatibility mode that was required in the v1.21.0 semantic convention.
The full PR is #5092
Part of #5331