-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update semconv to spec release 1.20.0 #579
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
=======================================
Coverage 38.11% 38.11%
=======================================
Files 61 61
Lines 3597 3597
=======================================
Hits 1371 1371
Misses 2226 2226
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Woops, changes seemed straightforward (autogenerated code) but tests appear to fail here and there. |
Ah, yup, Elixir module ends up with the wrong name with this change. |
I'm not familiar with the codegen tool, but would be great if we could maintain old attributes as deprecated and maybe aliases, example:
That works even for removed attributes, which deprecated message will say it's removed. My concern is to make it backward compatible as possible, otherwise this library will end up locking dozens of other libraries, given our approach for Erlang/Elixir to be micro-libraries for each instrumentation. Would be that possible? |
@@ -2,8 +2,8 @@ | |||
|
|||
set -ex | |||
|
|||
semconv_version='1.13.0' | |||
docker_img_vsn='0.14.0' | |||
semconv_version='1.20.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime, we got 1.21.0 released 😬
We could probably keep a list of them, mark them there and in the changelog, and then set a policy for removal. This doesn't get updated often so it doesn't seem like a big burden to add/modify. |
No description provided.