Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otel-collector] - rename otelcol to otel-collector #1841

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Dec 14, 2024

Changes

Renames otelcol to otel-collector

This is part of getting all services renamed based on the overall #1788 effort for all components in the demo.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@puckpuck puckpuck requested a review from a team as a code owner December 14, 2024 04:12
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Dec 14, 2024
@puckpuck puckpuck added the docs-update-required Requires documentation update label Dec 14, 2024
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add/move the otelcol-config-extras to the new folder.

Tested and now it works 🚀

Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder that the OpenTelemetry collector binary name is structred as otelcol-<distribution> in https://github.com/open-telemetry/opentelemetry-collector-releases/tree/main/distributions.

But for the OpenTelemetry demo, your name suggestion gives more context to the users.

@julianocosta89 julianocosta89 merged commit 9b7cfad into open-telemetry:main Dec 16, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-update-required Requires documentation update helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants