Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accounting]: rename accountingservice to accounting #1827

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Dec 12, 2024

Changes

Renames accountingservice to accounting.

This is the first service to get renamed based on the overall rename effort for all components in the demo.

I did a "Find All" for accountingservice and accounting_service without case sensitivity and manually updated each entry. I did a full docker prune, then ran docker compose build accounting followed by make start. Tested in Jaeger and Grafana that all telemetry data is working as intended.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@puckpuck puckpuck requested a review from a team as a code owner December 12, 2024 05:12
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Dec 12, 2024
@puckpuck puckpuck added the docs-update-required Requires documentation update label Dec 12, 2024
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor question

.gitignore Show resolved Hide resolved
.licenserc.json Show resolved Hide resolved
@julianocosta89 julianocosta89 merged commit e54439d into open-telemetry:main Dec 12, 2024
31 checks passed
@puckpuck
Copy link
Contributor Author

Ahh... technically we should of left the genproto stuff off. It was left over from when the accountingservice originally started as a go based service before being moved to .NET.

I'll write another PR to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-update-required Requires documentation update helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants