Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace manually adding tags with multimod #6292

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Replace manually adding tags with multimod #6292

merged 1 commit into from
Dec 1, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Oct 12, 2022 •
edited
Loading

Also, only creates tags for the modules not marked as ignored in the version file.

For the moment I cannot find way to push these tags, filed open-telemetry/opentelemetry-go-build-tools#157

@bogdandrutu bogdandrutu requested review from a team and codeboten October 12, 2022 20:40
@codecov
Copy link

codecov bot commented Oct 12, 2022 •
edited
Loading

Codecov Report

Base: 91.20% // Head: 91.20% // No change to project coverage 👍

Coverage data is based on head (0a26aee) compared to base (5fbf38f).
Patch has no changes to coverable lines.

❗ Current head 0a26aee differs from pull request most recent head 0b6994a. Consider uploading reports for the commit 0b6994a to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6292   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files         245      245           
  Lines       14194    14194           
=======================================
  Hits        12945    12945           
  Misses        999      999           
  Partials      250      250

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

codeboten
codeboten approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the tag deletion in this makefile no longer useful to have? I'm not sure how frequently it's been used (if at all)

This change will require an update to https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/release.md#releasing-opentelemetry-collector

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 12, 2022
@bogdandrutu bogdandrutu marked this pull request as draft October 12, 2022 21:39
@bogdandrutu
Copy link
Member Author

@codeboten until I find a way to push the tags will hold on this for the moment

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 27, 2022
@github-actions github-actions bot removed the Stale label Oct 28, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 12, 2022
@bogdandrutu bogdandrutu removed the Stale label Nov 23, 2022
@bogdandrutu bogdandrutu force-pushed the replacetags branch 2 times, most recently from c59342c to 0a26aee Compare November 30, 2022 22:25
@bogdandrutu bogdandrutu marked this pull request as ready for review November 30, 2022 22:26
@bogdandrutu
Copy link
Member Author

@codeboten @dmitryax please take a look.

@bogdandrutu bogdandrutu mentioned this pull request Nov 30, 2022
Merged
dmitryax
dmitryax approved these changes Dec 1, 2022
View reviewed changes
Makefile
multimod verify
set -e; for tag in `multimod tag -m ${MODSET} -c ${COMMIT} --print-tags | grep -v "Using" `; do \
echo "pushing tag $${tag}"; \
git push ${REMOTE} $${tag}; \
Copy link
Member

@dmitryax dmitryax Dec 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we had a dry-run option for git push just to show what tags are about to be pushed, but I think multimod tag ... will fail on a second run... Do you think it's something worth adding to multimod tag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can ask for that, please open an issue in the build-go repos.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted open-telemetry/opentelemetry-go-build-tools#205

@bogdandrutu bogdandrutu merged commit f35ed7e into open-telemetry:main Dec 1, 2022
@bogdandrutu bogdandrutu deleted the replacetags branch December 1, 2022 03:48
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
@bogdandrutu @jaronoff97
Replace manually adding tags with multimod (open-telemetry#6292)
93c2869 
Signed-off-by: Bogdan <[email protected]>

Signed-off-by: Bogdan <[email protected]>
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
@bogdandrutu @jaronoff97
Replace manually adding tags with multimod (open-telemetry#6292)
f5e033c 
Signed-off-by: Bogdan <[email protected]>

Signed-off-by: Bogdan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@codeboten codeboten codeboten approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdandrutu @codeboten @dmitryax