[DebugExporter] Add EventName from LogRecord to output #11967
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
commented
Dec 20, 2024
trask
reviewed
Dec 20, 2024
Co-authored-by: Trask Stalnaker <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11967 +/- ##
==========================================
- Coverage 91.62% 91.61% -0.02%
==========================================
Files 447 447
Lines 23739 23741 +2
==========================================
- Hits 21751 21750 -1
- Misses 1613 1615 +2
- Partials 375 376 +1 ☔ View full report in Codecov by Sentry. |
codeboten
reviewed
Dec 21, 2024
| @@ -38,6 +38,9 @@ func (textLogsMarshaler) MarshalLogs(ld plog.Logs) ([]byte, error) { | |||
| buf.logEntry("Timestamp: %s", lr.Timestamp()) | |||
| buf.logEntry("SeverityText: %s", lr.SeverityText()) | |||
| buf.logEntry("SeverityNumber: %s(%d)", lr.SeverityNumber(), lr.SeverityNumber()) | |||
| if lr.EventName() != "" { | |||
There was a problem hiding this comment.
can you ensure a test for this in https://github.com/open-telemetry/opentelemetry-collector/blob/main/exporter/debugexporter/internal/otlptext/logs_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes #11966
Testing
Manually tested with Otel client that exported a LogRecord with event name and without event name.
(1st time contributor here, still learning the process.)