-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zap as the default error log in confighttp #11935
Open
tarun-kavipurapu
wants to merge
17
commits into
open-telemetry:main
Choose a base branch
from
tarun-kavipurapu:fix-issue-#11820
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+30
−1
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
57e4cf0
Added Zap as the default Error log open-telemetry#11820
tarun-kavipurapu a9f3aeb
Added Zap as the default Error log open-telemetry#11820
tarun-kavipurapu 6582f98
Added Zap as the default Error log open-telemetry#11820
tarun-kavipurapu 5460f8d
change log
tarun-kavipurapu f9c3375
change log
tarun-kavipurapu 71c16e0
Added Zap as the default Error log open-telemetry#11820
tarun-kavipurapu e2b7c86
Added Zap as the default Error log open-telemetry#11820
tarun-kavipurapu bc33333
genotelcorecol done
tarun-kavipurapu 3a81191
Merge branch 'main' into fix-issue-#11820
codeboten 9a4d63d
Update cmd/otelcorecol/go.mod
codeboten c9ce37f
Merge branch 'main' into fix-issue-#11820
codeboten 69577a7
Merge branch 'main' into fix-issue-#11820
codeboten 84c248c
Merge branch 'main' into fix-issue-#11820
codeboten f31a5f7
Merge branch 'open-telemetry:main' into fix-issue-#11820
tarun-kavipurapu ebcc31e
Merge branch 'main' into fix-issue-#11820
mx-psi 4caff5f
Merge branch 'open-telemetry:main' into fix-issue-#11820
tarun-kavipurapu 58267e5
Update .chloggen/zap-default-errorlog.yaml
tarun-kavipurapu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: bug_fix | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver) | ||
component: confighttp | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: "Added Zap as the default error log in confighttp" | ||
|
||
# One or more tracking issues or pull requests related to the change | ||
issues: [11820] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: | ||
|
||
# Optional: The change log or logs in which this entry should be included. | ||
# e.g. '[user]' or '[user, api]' | ||
# Include 'user' if the change is relevant to end users. | ||
# Include 'api' if there is a change to a library API. | ||
# Default: '[user]' | ||
change_logs: [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should return errors as soon as they happen, not later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the suggested change was the initial code too
but in
https://github.com/open-telemetry/opentelemetry-collector/pull/11830/files/71c16e0b293b4d6ed25146c4dd295093e672afd7#r1880527497
it was suggested to return server,err so that to avoid coverage report failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, how about something like:
Then, we can handle multiple things that could return errors, and we also keep error return alongside its definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check the report locally and may be make the change according to it
the command for it is
make gotest-with-cover
right?