Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][confmap] Do not merge: demonstrate empty slice handling #11882

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

evan-bradley
Copy link
Contributor

Expands on #11755 to show how we could test for a 1:1 mapping between map[string]any <-> confmap.Conf <-> Config structs for []any(nil) and []any{} slices.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (d0f5bda) to head (84e4ced).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11882      +/-   ##
==========================================
+ Coverage   91.44%   91.59%   +0.14%     
==========================================
  Files         446      449       +3     
  Lines       23742    23761      +19     
==========================================
+ Hits        21712    21763      +51     
+ Misses       1654     1623      -31     
+ Partials      376      375       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant