Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add changelog entry for Dockerfile USER_GID as non root #11829

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add changelog entry for Dockerfile USER_GID as non root #11829

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb7f81b
add changelog entry for Dockerfile USER_GID as non root
rogercoll Dec 9, 2024
f763b3a
fix: changelog issue must be a str
rogercoll Dec 9, 2024
eada231
Update .chloggen/dockerfile_remove_root_group.yaml
rogercoll Dec 9, 2024
9593eba
fix: use image changelog entry component
rogercoll Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .chloggen/dockerfile_remove_root_group.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: 'enhancement'

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: container
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no container component in this repo, maybe use release or image instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Replaced in 9593eba


# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: "Set Dockerfile's USER_GID as non root. OpenTelemetry Collector releases issue: https://github.com/open-telemetry/opentelemetry-collector-releases/issues/662"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] can you not add the link to the issues: field below?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, you can only link issues / PRs in this repo in issues:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 🤷🏼


# One or more tracking issues or pull requests related to the change
issues: []
rogercoll marked this conversation as resolved.
Show resolved Hide resolved

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
Loading